Skip to content

feat: export isStore and isTask functions; update API documentation #7716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 25, 2025

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Jul 9, 2025

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

export isStore and isTask functions; update API documentation

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested review from a team as code owners July 9, 2025 10:18
Copy link

changeset-bot bot commented Jul 9, 2025

⚠️ No Changeset found

Latest commit: 2d1ef93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JerryWu1234 JerryWu1234 self-assigned this Jul 9, 2025
@JerryWu1234 JerryWu1234 moved this from Backlog to Waiting For Review in Qwik Development Jul 9, 2025
Copy link

pkg-pr-new bot commented Jul 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7716
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7716
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7716
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7716

commit: 2d1ef93

Copy link
Contributor

github-actions bot commented Jul 9, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 2d1ef93

@JerryWu1234 JerryWu1234 marked this pull request as draft July 10, 2025 06:38
@JerryWu1234 JerryWu1234 moved this from Waiting For Review to In progress in Qwik Development Jul 10, 2025
@JerryWu1234 JerryWu1234 moved this from In progress to Waiting For Review in Qwik Development Jul 11, 2025
@JerryWu1234 JerryWu1234 marked this pull request as ready for review July 11, 2025 06:31
@JerryWu1234
Copy link
Contributor Author

@wmertens done

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐃

@wmertens wmertens merged commit 02d046d into QwikDev:build/v2 Jul 25, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Jul 25, 2025
@shairez
Copy link
Contributor

shairez commented Jul 29, 2025

@JerryWu1234 can you please explain why did you need all of these things exported?

maybe we can reduce the surface area of the public exports to avoid potential future breaking changes (sometimes people use it although they are internal and it's better not to expose them if not absolutely necessary)

@shairez shairez moved this from Done to Waiting For Review in Qwik Development Jul 29, 2025
@JerryWu1234
Copy link
Contributor Author

@JerryWu1234 can you please explain why did you need all of these things exported?

maybe we can reduce the surface area of the public exports to avoid potential future breaking changes (sometimes people use it although they are internal and it's better not to expose them if not absolutely necessary)

I'm developing the Qwik Devtool right now. I have to use these APIs in DevTools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting For Review
Development

Successfully merging this pull request may close these issues.

3 participants